Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SYS_HAS_MAG parameter description #24186

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

MaEtUgR
Copy link
Member

@MaEtUgR MaEtUgR commented Jan 8, 2025

Solved Problem

after answering the questions:
Ah, the value can be 2? Should I set the number of magnetometers the board has or include the external ones?

Solution

I tried to find a concise description that should cover the confusion. Please correct if it's not clear.

Changelog Entry

Clarify SYS_HAS_MAG parameter description

after answering the questions:
Ah the value can be 2? Should I set the number of magnetometers the board has or include the external ones?
@MaEtUgR MaEtUgR requested review from bkueng and sdomoszlai13 January 8, 2025 13:40
@MaEtUgR MaEtUgR self-assigned this Jan 8, 2025
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that EKF2_MAG_TYPE should also be set to "none" if SYS_HAS_MAG == 0? Or do it automatically somewhere?

@dagar
Copy link
Member

dagar commented Jan 9, 2025

Should we mention that EKF2_MAG_TYPE should also be set to "none" if SYS_HAS_MAG == 0? Or do it automatically somewhere?

If you're feeling generous we could do it automatically in EKF2.

@dagar dagar merged commit b042f21 into main Jan 9, 2025
60 of 61 checks passed
@dagar dagar deleted the maetugr/sys_has_mag-description branch January 9, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants